added module data endpoint#326
Conversation
nicosammito
left a comment
nicosammito
left a comment
There was a problem hiding this comment.
Okay but what about actions? They can also have a module definition and this can be also updated on runtime
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
| string filter = 2; | ||
| string sort = 3; |
There was a problem hiding this comment.
We definitely need to think about this and typing this in a way that filtering and sorting is properly done.
generally a filter can is be an array of key and value with a operation in between. a sort should be a simple ASC DESC via a field.
There was a problem hiding this comment.
I think we should do both as shared.Value and not make this typed. We don't know how this will evolve
There was a problem hiding this comment.
I understand your idea. But than every action can develop there own searching and filtering and I'm not fine with that. This can become very massy very easily. Generally we start as low as possible and add new fields in the future.
There was a problem hiding this comment.
Remember, this will mean that we always need to do Sagittarius changes to make this possible.
Also Actions with a typed system then also need changes if just a change happened. And also every module data system is specific for an action. The Implementation will always be different.
There was a problem hiding this comment.
Remember, this will mean that we always need to do Sagittarius changes to make this possible.
Also Actions with a typed system then also need changes if just a change happened. And also every module data system is specific for an action. The Implementation will always be different.
For actions this will be implemented within the action sdk itself. So an actions doesn't need any updates. The IDE will need to update for sure, but we need to update it either way if we change something. So I would prefer a typed way.
There was a problem hiding this comment.
My idea for sort
message ModuleDataSort {
enum ModuleDataSortDirection {
UNKNOWN = 0;
ASC = 1;
DESC = 2;
}
string field = 1;
ModuleDataSortDirection direction = 2;
} There was a problem hiding this comment.
My idea for sort
message ModuleDataSort { enum ModuleDataSortDirection { UNKNOWN = 0; ASC = 1; DESC = 2; } string field = 1; ModuleDataSortDirection direction = 2; }
Yep I'm fine with that for sort
There was a problem hiding this comment.
We'll discuss the filter on our meeting this Tuesday
Co-authored-by: Nico Sammito <nsammito@code0.tech> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
|
I've removed the |
| string sort = 3; | ||
| repeated ModuleDataFilter filter = 2; | ||
| repeated ModuleDataSort sort = 3; | ||
| string cursor = 4; |
There was a problem hiding this comment.
We have a cursor here but its not linked to PageInfo and ModuleData at all
There was a problem hiding this comment.
Explain? Do you want to have a typed Cursor Object?
Co-authored-by: Nico Sammito <nsammito@code0.tech> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
|
@nicosammito @Taucher2003 is this ready to be merged? |
Resolves: #321
This draft can be already reviewed. I decided to add a taurus endpoint => Aquila will ask Taurus for Module Data, this way its easier to implement and would be more resource efficient, if this is not possible I would replicate as its done in sagittarius.module.proto
If you both approve of the changes, ill do the needed adjustments for Taurus Build Steps
@Taucher2003 @nicosammito